Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https://cantstop.fun to notable projects #846

Merged

Conversation

simlmx
Copy link
Contributor

@simlmx simlmx commented Nov 23, 2020

Adding cantstop.fun to the notable projects list.

I wasn't exactly sure where to put it in the list: I followed the almost alphabetical order.
I'm happy to create a following PR sorting everything in alphabetical order if you folks think it's a good idea.

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

@delucis delucis merged commit 5d34610 into boardgameio:master Nov 23, 2020
@delucis
Copy link
Member

delucis commented Nov 23, 2020

Thanks @simlmx! There hasn’t been any strict order, but PRs are always welcome :-)

@simlmx
Copy link
Contributor Author

simlmx commented Nov 23, 2020

Cool!

While I'm at it what do you think of switching the game page and the code urls? I think people expect to get to the game when they click on the game's name. So items of the list could look like

@delucis
Copy link
Member

delucis commented Nov 23, 2020

Why not? There are a few variations and not each project is a game, so maybe the name could just be bolded and then there could be three categories of link: play / code / tutorial, e.g.:

  • Can't Stop! - play / code - The classic "push your luck" dice game.

Thanks for this!

@simlmx
Copy link
Contributor Author

simlmx commented Nov 23, 2020

Good point! I'll try something out today or tomorrow and we can always iterate on the PR!

You're welcome and thanks to you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants