Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating logging methods to be spied upon after framework is loaded. #917 #918

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Updating logging methods to be spied upon after framework is loaded. #917 #918

merged 1 commit into from
Mar 7, 2021

Conversation

cha55son
Copy link
Contributor

@cha55son cha55son commented Mar 7, 2021

Closes #917

Allows logging to be spied after the framework has been loaded. Eases testing of invalid moves.

delucis
delucis approved these changes Mar 7, 2021
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cha55son!

Worth noting that logging is an internal API so we probably can’t guarantee that at some future time your tests might be broken by internal changes, but I appreciate that in the absence of #592 (or #723) it’s the best option available currently.

@delucis delucis merged commit 0bab885 into boardgameio:master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating logging functions for spying after framework is loaded
2 participants
@cha55son @delucis