Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): playerID in playerView can be string or null #990

Merged

Conversation

ben196888
Copy link
Contributor

This pull request relates to issue #989.

Recap: the playerID in PlayerView could be null when the user is in spectator mode.
Changes:

  • update playerID type to be PlayerID | null
  • mention the playerID would be null in secret-state document page

Checklist

  • Use a separate branch in your local repo (not main).
  • Test coverage is 100% (or you have a story for why it's ok).

@delucis delucis changed the title fix(types): playerID should be type PlayerID or null fix(types): playerID in playerView can be string or null (#990) Aug 26, 2021
@delucis delucis changed the title fix(types): playerID in playerView can be string or null (#990) fix(types): playerID in playerView can be string or null Aug 26, 2021
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ben196888!

@delucis delucis merged commit f18c63a into boardgameio:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants