Separate prod and dev env for batch submitter (#122)

* kms in bs

* KMS only

* cleanup 1

* rm prvt keys checks

* correct address to proposer

* cleanup + add req env vars

* fix flags tests

* start KMS soon

* rm dead code, pull KMS before the stack starts up

* start KMS and wait for it

* bump urface/cli

* logs kms, clear cache

* restart batch submitter on error

* env var credentials

* fix tests for pending tx

* comments in dc

* log

* Separate prod and dev env

* Fix lint

* Remove KMS waiting script

* Use default session settings

* Add KMS region

Co-authored-by: Ino Murko <ino@enya.ai>
Co-authored-by: CAPtheorem <79423264+CAPtheorem@users.noreply.github.com>

go/batch-submitter/batch_submitter.go

@@ -117,6 +117,12 @@ func Main(gitVersion string) func(ctx *cli.Context) error {
 			Region:      aws.String(cfg.KmsRegion),
 			Endpoint:    aws.String(cfg.KmsEndpoint)},
 		)
+		// AWS uses IAM role for task
+		if cfg.BuildEnv == "production" {
+			sess, _ = session.NewSession(&aws.Config{
+				Region: aws.String(cfg.KmsRegion)},
+			)
+		}
 		svc := kms.New(sess)
 		var services []*bsscore.Service
 		if cfg.RunTxBatchSubmitter {

ops/scripts/batch-submitter.sh

@@ -24,19 +24,5 @@ curl --fail \
     --output /dev/null \
     $L2_ETH_RPC
 
-echo "waits for kms to be up"
-curl \
-    -X POST \
-    --silent \
-    --fail \
-    --show-error \
-    -H "Content-Type: application/json" \
-    -H "X-Amz-Target:TrentService.ListKeys" \
-    --retry-connrefused \
-    --retry $RETRIES \
-    --retry-delay 3 \
-    --output /dev/null \
-    $BATCH_SUBMITTER_KMS_ENDPOINT
-
 # go
 exec batch-submitter "$@"