Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket support for teleportation #1025

Closed
wants to merge 10 commits into from
Closed

Websocket support for teleportation #1025

wants to merge 10 commits into from

Conversation

wsdt
Copy link
Contributor

@wsdt wsdt commented Jul 14, 2023 •
edited
Loading

📋 Resolves #993

Overview

Added Websocket support Teleportation.

Changes

  • Added WS specific integration test
  • Teleportation service uses by default Websocket if provided, if not it falls back to previous http polling strategy
  • Websocket and http providers can be mixed, as there might not be a websocket for every supported network.
  • Websocket checks via http first for previous events based on saved lastBlock.

Testing

  • Websocket tests run through
  • Previous tests work too (for both httpProvider and wsProvider)

@wsdt wsdt marked this pull request as draft July 14, 2023 15:47
@wsdt wsdt marked this pull request as ready for review July 17, 2023 10:35
souradeep-das
souradeep-das approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@souradeep-das souradeep-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

packages/boba/teleportation/src/service.ts Outdated Show resolved Hide resolved
wsdt
wsdt commented Jul 17, 2023
View reviewed changes
packages/boba/teleportation/src/utils/chains.ts
@@ -21,6 +25,7 @@ export const BobaChains: IBobaChains = {
//#region boba_networks
288: {
url: 'https://replica.boba.network',
// wsUrl: 'wss://boba-ethereum.gateway.tenderly.co',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not using ws for now

@InoMurko
Copy link
Contributor

Closed for now as it's not needed, we can bring it back if it becomes a neccessety

@InoMurko InoMurko closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souradeep-das souradeep-das souradeep-das approved these changes

@InoMurko InoMurko Awaiting requested review from InoMurko

@boyuan-chen boyuan-chen Awaiting requested review from boyuan-chen

Assignees
No one assigned
Labels
2-reviewers M-integration M-ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding WS instead of Polling events (Teleporter)
3 participants
@wsdt @InoMurko @souradeep-das