initial dao page #988
Closed
initial dao page #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sk-enya
reviewed
Jul 4, 2023
| @@ -16,14 +16,15 @@ limitations under the License. */ | |||
| import React, { useState } from 'react' | |||
There was a problem hiding this comment.
Why it's not written as typescript? can you please migrate to typescript and have some basic test around it?
|
Can you please update with develop branch? |
|
Can you please confirm which PR has to be merge? As I can see same changes on the another one as well. |
|
Closing the PR as changes have been already handled in the below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The DAO page was updated to the new gateway version 2.5, unnecessary texts have been removed.
The backgrounds of the MUI version were globally updated.
The Connect component was updated to match the design style of version 2.5.
We added a new tabHeader component.
We added a new variant to the button component, outline, which will be used in other views.
IMPORTANT:
The detail of the proposals is not updated yet because the connect component is still not functioning. Once the connect button is updated and working, we can update the pending style for the internal tabs.