Skip to content

Commit

Permalink
Fix README and examples 😅
Browse files Browse the repository at this point in the history
I tried to run the examples this morning and found that the docs were
wrong and also that the path in the example pipelines was now incorrect.
I can see how the docs could get out of sync but something odd is
happening with the pipeline paths b/c our tests should be catching that,
so I'll open a bug. In the meantime, these changes make it so we can at
least successfully create the pipelinerun (also tried the taskrun, which
works - I haven't tried the other examples).
  • Loading branch information
bobcatfish committed Feb 6, 2019
1 parent 0dd80f4 commit bd22691
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions examples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@ To deploy them to your cluster (after
kubectl apply -f examples/

# To invoke the build-push Task only
kubectl apply -f examples/run/task-run.yaml
kubectl apply -f examples/run/taskrun.yaml

# To invoke the simple Pipeline
kubectl apply -f examples/run/pipeline-run.yaml
kubectl apply -f examples/run/pipelinerun.yaml

# To invoke the Pipeline that links outputs
kubectl apply -f examples/run/output-pipeline-run.yaml
kubectl apply -f examples/run/output-pipelinerun.yaml

# To invoke the TaskRun with embedded Resource spec and task Spec
kubectl apply -f examples/run/task-run-resource-spec.yaml
kubectl apply -f examples/run/resource-spec-taskrun.yaml
```

## Example Pipelines
Expand Down
8 changes: 4 additions & 4 deletions examples/pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
- name: pathToDockerFile
value: Dockerfile
- name: pathToContext
value: /workspace/examples/microservices/leeroy-web
value: /workspace/workspace/examples/microservices/leeroy-web
resources:
inputs:
- name: workspace
Expand All @@ -33,7 +33,7 @@ spec:
- name: pathToDockerFile
value: Dockerfile
- name: pathToContext
value: /workspace/examples/microservices/leeroy-app
value: /workspace/workspace/examples/microservices/leeroy-app
resources:
inputs:
- name: workspace
Expand All @@ -54,7 +54,7 @@ spec:
- build-skaffold-app
params:
- name: path
value: /workspace/examples/microservices/leeroy-app/kubernetes/deployment.yaml
value: /workspace/workspace/examples/microservices/leeroy-app/kubernetes/deployment.yaml
- name: yqArg
value: "-d1"
- name: yamlPathToImage
Expand All @@ -72,7 +72,7 @@ spec:
- build-skaffold-web
params:
- name: path
value: /workspace/examples/microservices/leeroy-web/kubernetes/deployment.yaml
value: /workspace/workspace/examples/microservices/leeroy-web/kubernetes/deployment.yaml
- name: yqArg
value: "-d1"
- name: yamlPathToImage
Expand Down

0 comments on commit bd22691

Please sign in to comment.