Skip to content

Commit

Permalink
Fix botched rename of PipelineTrigger field 😢
Browse files Browse the repository at this point in the history
In tektoncd#366 I tried to rename the trigger field in a `PipelineRun.Spec` from
`PipelineTrigger` to just `Trigger` to be in line with the similar
`Trigger` field in `TaskRun.Spec` BUT I MISSED SOME OF THEM 😭😭😭

Fixes tektoncd#366
  • Loading branch information
bobcatfish committed Jan 8, 2019
1 parent 79fe4a6 commit f1a10f8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/helm_task_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ func getHelmDeployPipelineRun(namespace string) *v1alpha1.PipelineRun {
PipelineRef: v1alpha1.PipelineRef{
Name: helmDeployPipelineName,
},
PipelineTrigger: v1alpha1.PipelineTrigger{
Trigger: v1alpha1.PipelineTrigger{
Type: v1alpha1.PipelineTriggerTypeManual,
},
PipelineTaskResources: []v1alpha1.PipelineTaskResource{{
Expand Down
4 changes: 2 additions & 2 deletions test/pipelinerun_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ func getFanInFanOutPipelineRun(suffix int, namespace string) *v1alpha1.PipelineR
PipelineRef: v1alpha1.PipelineRef{
Name: getName(hwPipelineName, suffix),
},
PipelineTrigger: v1alpha1.PipelineTrigger{
Trigger: v1alpha1.PipelineTrigger{
Type: v1alpha1.PipelineTriggerTypeManual,
},
PipelineTaskResources: []v1alpha1.PipelineTaskResource{
Expand Down Expand Up @@ -590,7 +590,7 @@ func getHelloWorldPipelineRun(suffix int, namespace string) *v1alpha1.PipelineRu
PipelineRef: v1alpha1.PipelineRef{
Name: getName(hwPipelineName, suffix),
},
PipelineTrigger: v1alpha1.PipelineTrigger{
Trigger: v1alpha1.PipelineTrigger{
Type: v1alpha1.PipelineTriggerTypeManual,
},
ServiceAccount: fmt.Sprintf("%s%d", hwSA, suffix),
Expand Down

0 comments on commit f1a10f8

Please sign in to comment.