This repository has been archived by the owner on Mar 15, 2020. It is now read-only.
Adding headers to HTTPError #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,6 +48,7 @@ | |||
| ``` | |||
| """ | |||
| res.status_code = exc.status_code | |||
| res.headers = exc.headers | |||
There was a problem hiding this comment.
I think some of the tests failing in CI come from this line. We shouldn’t set response headers if exc.headers is None. :)
There was a problem hiding this comment.
oh duh its optional, ill change that. well what about adding it to slots?
There was a problem hiding this comment.
__slots__ = (status, detail, headers )
Since headers is optional I figured it would not be included
There was a problem hiding this comment.
We can certainly add it, yes.
|
Yup, I think this is the way I initially thought about this. :) |
|
@teaglebuilt Bocadillo has now entered unmaintained state, as per #334. I'm closing this PR as a result. Thanks for your interest. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**In Response to Issue #275 **
Issue #275
I wanted to see if this is what you had in mind? I also read the link regarding the issue about adding to HTTPException and abondoning HTTPError?
#507
If you noticed I just added the headers to HTTPError and the handlers. I wanted to see which direction you are referring to?