VarargsParameterResolver should only support varargs as the last parameter, not an array #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter, not an array. The previous behaviour was causing the VarargsParameterResolver to resolve the @Row("example") for a test method like public void test(String[] argument) as: new Object[]{new String{"example"}} when I need it to resolve as: new Object[]{"example"} for a ParameterResolver plugin for yatspec I am working on that will delegate to VarargsParameterResolver to deal with varargs and add some additional functionality on top of that.
danielbodart
added a commit
that referenced
this pull request
Mar 20, 2016
VarargsParameterResolver should only support varargs as the last parameter, not an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behaviour was causing the
VarargsParameterResolverto resolve the@Row("example")for a test method likepublic void test(String[] argument)as:new Object[]{new String{"example"}}when I need it to resolve as:
new Object[]{"example"}for a
ParameterResolverplugin for yatspec I am working on that will delegate toVarargsParameterResolverto deal with varargs and add some additional functionality on top of that.