Skip to content

Commit

Permalink
[chore] remove WithOTel test wrapper (open-telemetry#10236)
Browse files Browse the repository at this point in the history
This is no longer needed since we're not testing WithOTel and
WithOpenCensus.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
  • Loading branch information
codeboten authored May 28, 2024
1 parent b111528 commit b53ba2c
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 27 deletions.
10 changes: 4 additions & 6 deletions exporter/exporterhelper/obsexporter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,9 @@ type testParams struct {
}

func testTelemetry(t *testing.T, id component.ID, testFunc func(t *testing.T, tt componenttest.TestTelemetry)) {
t.Run("WithOTel", func(t *testing.T) {
tt, err := componenttest.SetupTelemetry(id)
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, tt.Shutdown(context.Background())) })
tt, err := componenttest.SetupTelemetry(id)
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, tt.Shutdown(context.Background())) })

testFunc(t, tt)
})
testFunc(t, tt)
}
4 changes: 1 addition & 3 deletions processor/batchprocessor/metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ type expectedMetrics struct {
}

func telemetryTest(t *testing.T, testFunc func(t *testing.T, tel testTelemetry)) {
t.Run("WithOTel", func(t *testing.T) {
testFunc(t, setupTelemetry(t))
})
testFunc(t, setupTelemetry(t))
}

func setupTelemetry(t *testing.T) testTelemetry {
Expand Down
10 changes: 4 additions & 6 deletions processor/processorhelper/obsreport_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,9 @@ func TestCheckProcessorLogViews(t *testing.T) {
}

func testTelemetry(t *testing.T, id component.ID, testFunc func(t *testing.T, tt componenttest.TestTelemetry)) {
t.Run("WithOTel", func(t *testing.T) {
tt, err := componenttest.SetupTelemetry(id)
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, tt.Shutdown(context.Background())) })
tt, err := componenttest.SetupTelemetry(id)
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, tt.Shutdown(context.Background())) })

testFunc(t, tt)
})
testFunc(t, tt)
}
10 changes: 4 additions & 6 deletions receiver/receiverhelper/obsreport_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,11 +297,9 @@ func TestCheckReceiverLogsViews(t *testing.T) {
}

func testTelemetry(t *testing.T, id component.ID, testFunc func(t *testing.T, tt componenttest.TestTelemetry)) {
t.Run("WithOTel", func(t *testing.T) {
tt, err := componenttest.SetupTelemetry(id)
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, tt.Shutdown(context.Background())) })
tt, err := componenttest.SetupTelemetry(id)
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, tt.Shutdown(context.Background())) })

testFunc(t, tt)
})
testFunc(t, tt)
}
10 changes: 4 additions & 6 deletions receiver/scraperhelper/obsreport_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,9 @@ func TestCheckScraperMetricsViews(t *testing.T) {
}

func testTelemetry(t *testing.T, id component.ID, testFunc func(t *testing.T, tt componenttest.TestTelemetry)) {
t.Run("WithOTel", func(t *testing.T) {
tt, err := componenttest.SetupTelemetry(id)
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, tt.Shutdown(context.Background())) })
tt, err := componenttest.SetupTelemetry(id)
require.NoError(t, err)
t.Cleanup(func() { require.NoError(t, tt.Shutdown(context.Background())) })

testFunc(t, tt)
})
testFunc(t, tt)
}

0 comments on commit b53ba2c

Please sign in to comment.