Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Prometheus #440

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

nadinelyab
Copy link
Contributor

There was a breaking change in the latest prometheus package and the FmtText used by the printer no longer exists. This upgrades ghz to use the latest prometheus and the printer uses NewFormat(expfmt.TypeTextPlain) instead.

Without this we have to keep prometheus at an older version in order to use ghz.

@nadinelyab
Copy link
Contributor Author

@bojand sorry to bother again but let me know if we could merge this to support latest Prometheus

@bojand bojand merged commit e2a3e15 into bojand:master May 29, 2024
2 checks passed
@bojand
Copy link
Owner

bojand commented May 30, 2024

Hello, thanks for the PR. Sorry somehow missed it. Released in 0.119.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants