Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade go version -> 1.20 #452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

behnambm
Copy link

the go.mod and readme files are not up to date.
Due to upgraded github.com/prometheus/common, ghz will only compile with version 1.20 or higher.

The compile time error(on go1.19.13 linux/amd64):

go: downloading cloud.google.com/go/compute v1.20.1
# github.com/prometheus/common/model
pkg/mod/github.com/prometheus/common@v0.53.0/model/metric.go:364:33: undefined: strings.CutPrefix
note: module requires Go 1.20

this is due to `github.com/prometheus/common` incompatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant