geodot kills godot if requested file does not exist

[chrisgraf]

see discord and remarks in 34a3c49

[kb173]

Thanks for the remarks! Should we just return null and leave the error handling to the GDScript code? (+ output a proper Godot Error)
That would be consistent with GDScript's load and preload functions, for example.

[chrisgraf]

Yes, the error should be handled where we have our "proper" logging and the code has enough information to estimate the impact of the failed call. So handling this in GDScript seems correct to me.

[kb173]

The crash should be prevented with c7c6064 - an empty list is returned if the dataset is invalid. Currently, an error is printed to the console saying that the dataset couldn't be opened, but we'd want to get this error into Godot. We might need to use Exceptions for this. They're not commonly used in game development, so I'm not sure whether we want to bring them into Geodot?

[kb173]

Seems like with GDExtension there are ways to properly propagate errors to Godot like ERR_FAIL_V_MSG (see the Godot XR reference project https://github.com/GodotVR/godot_xr_reference/blob/master/src/xr_interface_reference.cpp)

[kb173]

Blocked by godotengine/godot-cpp#521