Return STAT response as a multi-line in accordance with RFC 959 (#381)

Fixes issue #380

src/server/controlchan/commands/stat.rs

@@ -31,7 +31,7 @@ use crate::{
 };
 use async_trait::async_trait;
 use bytes::Bytes;
-use std::{io::Read, sync::Arc};
+use std::sync::Arc;
 use tokio::sync::mpsc::Sender;
 
 #[derive(Debug)]
@@ -86,19 +86,13 @@ where
                 let logger = args.logger;
 
                 tokio::spawn(async move {
-                    match storage.list_fmt((*user).as_ref().unwrap(), path).await {
-                        Ok(mut cursor) => {
-                            let mut result: String = String::new();
-                            match cursor.read_to_string(&mut result) {
-                                Ok(_) => {
-                                    if let Err(err) = tx_success
-                                        .send(ControlChanMsg::CommandChannelReply(Reply::new_with_string(ReplyCode::CommandOkay, result)))
-                                        .await
-                                    {
-                                        slog::warn!(logger, "{}", err);
-                                    }
-                                }
-                                Err(err) => slog::warn!(logger, "{}", err),
+                    match storage.list_vec((*user).as_ref().unwrap(), path).await {
+                        Ok(lines) => {
+                            if let Err(err) = tx_success
+                                .send(ControlChanMsg::CommandChannelReply(Reply::new_multiline(ReplyCode::CommandOkay, lines)))
+                                .await
+                            {
+                                slog::warn!(logger, "{}", err);
                             }
                         }
                         Err(e) => {

src/server/controlchan/line_parser/error.rs

@@ -16,6 +16,7 @@ pub struct ParseError {
 ///
 /// [ParseError]: ./struct.ParseError.html
 #[derive(Clone, Eq, PartialEq, Debug, Display)]
+#[allow(clippy::enum_variant_names)]
 pub enum ParseErrorKind {
     /// The client issued an invalid command (e.g. required parameters are missing).
     #[display(fmt = "Invalid command")]

src/storage/storage_backend.rs

@@ -218,6 +218,19 @@ pub trait StorageBackend<User: UserDetail>: Send + Sync + Debug {
         Ok(std::io::Cursor::new(file_infos))
     }
 
+    /// Returns directory listing as a vec of strings used for multi line response in the control channel.
+    #[tracing_attributes::instrument]
+    async fn list_vec<P>(&self, user: &User, path: P) -> std::result::Result<Vec<String>, Error>
+    where
+        P: AsRef<Path> + Send + Debug,
+        Self::Metadata: Metadata + 'static,
+    {
+        let inlist = self.list(user, path).await?;
+        let out = inlist.iter().map(|fi| fi.to_string()).collect::<Vec<String>>();
+
+        Ok(out)
+    }
+
     /// Returns some bytes that make up a NLST directory listing (only the basename) that can
     /// immediately be sent to the client.
     #[allow(clippy::type_complexity)]