parsing bye command as quit & tests

bolcom · Mar 14, 2023 · ea46f79 · ea46f79
1 parent 469aa36
commit ea46f79
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/server/controlchan/line_parser/parser.rs b/src/server/controlchan/line_parser/parser.rs
@@ -195,7 +195,7 @@ where
             let path = String::from_utf8_lossy(&path).to_string();
             Command::Rmd { path }
         }
-        "QUIT" => {
+        "QUIT" | "BYE" => {
             let params = parse_to_eol(cmd_params)?;
             if !params.is_empty() {
                 return Err(ParseErrorKind::InvalidCommand.into());

diff --git a/src/server/controlchan/line_parser/tests.rs b/src/server/controlchan/line_parser/tests.rs
@@ -329,6 +329,15 @@ fn parse_quit() {
     assert_eq!(parse(input), Err(ParseError::from(ParseErrorKind::InvalidCommand)));
 }
 
+#[test]
+fn parse_bye() {
+    let input = "BYE\r\n";
+    assert_eq!(parse(input), Ok(Command::Quit));
+
+    let input = "BYE BYE\r\n";
+    assert_eq!(parse(input), Err(ParseError::from(ParseErrorKind::InvalidCommand)));
+}
+
 #[test]
 fn parse_mkd() {
     let input = "MKD\r\n";