Implement per user IP allow lists #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesdejager
force-pushed
the
hannes/ip-whitelist
branch
3 times, most recently
from
a9f9c42
to
74d0c42
Compare
robklg
reviewed
May 28, 2021
hannesdejager
force-pushed
the
hannes/ip-whitelist
branch
2 times, most recently
from
5fb0337
to
d147e9f
Compare
robklg
reviewed
May 28, 2021
robklg
approved these changes
May 28, 2021
hannesdejager
force-pushed
the
hannes/ip-whitelist
branch
from
d147e9f
to
9a6303b
Compare
This commit allows libunftp authenticators to also consider the source IP when making authentication decisions. It then implements a basic allow list functionality in `unftp-auth-jsonfile`. Furthermore it readies the authenticator interface to also check the client certificate chain. This unfortunately introduces a breaking change in the Authenticator API.
hannesdejager
force-pushed
the
hannes/ip-whitelist
branch
from
9a6303b
to
404414c
Compare
|
Pertains to #344 |
This was referenced May 28, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows libunftp authenticators to also consider the source IP when making authentication decisions. It then implements a basic allow list functionality in
unftp-auth-jsonfile.Furthermore it readies the authenticator interface to also check the client certificate chain.
This unfortunately introduces a breaking change in the Authenticator API.