Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement source IP in REST authenticator #492

Merged
merged 6 commits into from
Dec 24, 2023
Merged

Implement source IP in REST authenticator #492

merged 6 commits into from
Dec 24, 2023

Conversation

robklg
Copy link
Contributor

@robklg robklg commented Nov 28, 2023

Solves #491

hannesdejager
hannesdejager approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@hannesdejager hannesdejager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fbs
fbs approved these changes Dec 13, 2023
View reviewed changes
crates/unftp-auth-rest/src/lib.rs Outdated Show resolved Hide resolved
crates/unftp-auth-rest/src/lib.rs Outdated Show resolved Hide resolved
robklg and others added 4 commits December 24, 2023 12:55
@robklg
Can be compacted
6fb7458
@robklg
Changelog entry
a55b455
@robklg
Replaced trim_matches with custom trim_quotes
e1c4621 
trim_matches repeatedly removes quotes, which is a potential security issue.
@robklg
Minor doc touch-up
7622e20
@robklg robklg merged commit cc81120 into master Dec 24, 2023
3 checks passed
@robklg robklg deleted the rest branch December 24, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannesdejager hannesdejager hannesdejager approved these changes

@fbs fbs fbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robklg @fbs @hannesdejager