Add storage permissions to UserDetail #511
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
reviewed
May 15, 2024
There was a problem hiding this comment.
This looks pretty good to me. BTW some of these permissions don't correspond 1:1 to Capsicum rights. For example, GET and LIST would both require CAP_READ but nothing else. So the storage backend itself will also have to validate rights. But it would have to do that anyway, if we want the rights to be enforced on !FreeBSD.
Do you want a permission like STAT that allows the SIZE and MDTM commands? Or should they come along with LIST?
hannesdejager
force-pushed
the
hannes/storage-perms
branch
from
b71a2cb
to
aa56544
Compare
This extends the UserDetail trait with a storage_permissions method that allow storage back-ends to limit what a user can do.
hannesdejager
force-pushed
the
hannes/storage-perms
branch
from
aa56544
to
709eb7b
Compare
|
ping. What does this PR still need? |
Hey sorry @asomers , I've been so focussed on the book I'm writing I've neglected and forgotten about this. Will try to attend to it in the next couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the UserDetail trait with a storage_permissions method that allow storage back-ends to limit what a user can do.