-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add azblob storage backend with opendal #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly look good to me from my view, great work!
@George-Miao Great stuff! Thank you! I’ll have a look over the week-end. We’ll need the unftp-sbe-opendal to release before merge. |
Hi, unftp-sbe-opendal v0.0.1 has been released: https://crates.io/crates/unftp-sbe-opendal Please check it out. |
I have updated the dependency |
We have compilation errors when the We should also add this feature to the different builds in the github actions file. |
You can add |
|
@George-Miao I think there was a ticket to fix that |
@George-Miao looking much better only the gnu build is failing now |
This PR adds azure blob support with OpenDAL. Currently we are still waiting for
unftp-sbe-opendal
to release, so it's a git dependency for now. Azure blob can be used as an example for future implementation of storages backed by OpenDAL.I'm not sure how should we organize the naming (arg, env) for services provided by OpenDAL though.
Closes #183