Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add azblob storage backend with opendal #184

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

George-Miao
Copy link
Contributor

@George-Miao George-Miao commented Jul 3, 2024

This PR adds azure blob support with OpenDAL. Currently we are still waiting for unftp-sbe-opendal to release, so it's a git dependency for now. Azure blob can be used as an example for future implementation of storages backed by OpenDAL.

I'm not sure how should we organize the naming (arg, env) for services provided by OpenDAL though.

Closes #183

Copy link

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly look good to me from my view, great work!

src/main.rs Outdated Show resolved Hide resolved
@hannesdejager
Copy link
Collaborator

@George-Miao Great stuff! Thank you! I’ll have a look over the week-end. We’ll need the unftp-sbe-opendal to release before merge.

@Xuanwo
Copy link

Xuanwo commented Jul 3, 2024

Hi, unftp-sbe-opendal v0.0.1 has been released: https://crates.io/crates/unftp-sbe-opendal

Please check it out.

@George-Miao
Copy link
Contributor Author

I have updated the dependency

Cargo.toml Outdated Show resolved Hide resolved
@hannesdejager
Copy link
Collaborator

hannesdejager commented Jul 4, 2024

We have compilation errors when the azblob feature is switched off. You will want only enable the code if this feature is on.

We should also add this feature to the different builds in the github actions file.

@hannesdejager
Copy link
Collaborator

hannesdejager commented Jul 4, 2024

You can add unftp-sbe-opendal to the Known storage back-ends list at https://github.com/bolcom/unFTP/blob/master/docs/libunftp/README.md

@George-Miao
Copy link
Contributor Author

We have compilation errors when the azblob feature is switched off.

unftp_sbe_gcs will also cause the compilation error when default features are turned off. Is that on purpose?

@hannesdejager
Copy link
Collaborator

@George-Miao I think there was a ticket to fix that

@hannesdejager
Copy link
Collaborator

@George-Miao looking much better only the gnu build is failing now

@hannesdejager hannesdejager merged commit 39ad118 into bolcom:master Jul 10, 2024
11 checks passed
@George-Miao George-Miao deleted the opendal-sbe branch July 11, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New storage backend: OpenDAL
3 participants