Website: Fix UNFTP_ROOT_URL in docker docs and add more passive ports #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I opened this PR against the gh-pages branch. I haven't used github pages personally so lmk if that's not correct or if there's more work needed than this. |
|
Thank you @paul-hansen, you can just make your pull request against master please. The gh-pages branch is only used when we build the documentation. |
|
Ah I think I see where it is now. I'll get it fixed up here in a bit. |
|
New PR is up! #189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ROOT_URL was incorrect and should have been UNFTP_ROOT_URL. Has been discussed in this issue: #164
Adds more passive ports to help avoid issues until #187 is resolved.