[INTER-3426] - Load Quote and Collect Totals Before Returning Set Shipping Method Response #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimeBones
requested review from
NickolasMalovanets,
victor-petryk and
pavel-bystritskyi
nicolenorman
approved these changes
May 2, 2024
kfalkowski11
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load and validate the quote after setting the shipping line and collect totals so we return a complete and up to date quote to the platform connector. This will prevent having the platform connector to make an extra request to get the quote again right after setting shipping lines. Set Quote Shipping Method now returns an identical response after setting the method to what the get quote endpoint does.
Without this the response from setQuoteShippingMethod had a few issues:
This change is to be done with Platform Connector PR