Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast checkout hydrateOrder endpoint #261

Merged
merged 4 commits into from
May 29, 2024
Merged

Conversation

nicolenorman
Copy link
Contributor

Add a new class which hits the fast checkout hydrate order endpoint.

This will hydrate a Bold simple order type with data from a Magento quote.

@nicolenorman nicolenorman marked this pull request as ready for review May 27, 2024 14:11
@nicolenorman nicolenorman marked this pull request as draft May 27, 2024 21:09
@nicolenorman nicolenorman marked this pull request as draft May 27, 2024 21:09
@nicolenorman nicolenorman marked this pull request as ready for review May 28, 2024 16:54
.gitignore Show resolved Hide resolved
Copy link
Contributor

@mwraich mwraich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So looks good, testing on my shop though I got the following error:

{
    "status": 422,
    "errors": [
        "{\"errors\":[\"Error at '\\\/totals\\\/discount_total': Value is not nullable\"],\"message\":\"Request validation failed for the reasons noted\"}"
    ],
    "body": []
}

I didn't have a discount present.

Model/Order/HydrateOrderFromQuote.php Show resolved Hide resolved
Model/Order/HydrateOrderFromQuote.php Show resolved Hide resolved
Model/Order/HydrateOrderFromQuote.php Show resolved Hide resolved
@nicolenorman
Copy link
Contributor Author

So looks good, testing on my shop though I got the following error:

{
    "status": 422,
    "errors": [
        "{\"errors\":[\"Error at '\\\/totals\\\/discount_total': Value is not nullable\"],\"message\":\"Request validation failed for the reasons noted\"}"
    ],
    "body": []
}

I didn't have a discount present.

Thank you for catching this @mwraich ! Just pushed a small change to account for no discounts.

@nicolenorman nicolenorman merged commit 1798d82 into main May 29, 2024
@nicolenorman nicolenorman deleted the order-hydrate-endpoint branch May 29, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants