Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

META-334: Fix duplicate bold checkout orders #302

Merged
merged 1 commit into from
Aug 6, 2024
Merged

META-334: Fix duplicate bold checkout orders #302

merged 1 commit into from
Aug 6, 2024

Conversation

zliu7878
Copy link
Contributor

@zliu7878 zliu7878 commented Jul 30, 2024

Issue:

  • The bold_checkout_order is currently saved twice in the db, first in the CheckoutSubmitAllAfterObserver, and then again the at the place order endpoint

Fix:

  • Add a check at the place order endpoint and only save to the bold_checkout_order if the mangeto order with the bold public id does not exist in the db

Copy link
Contributor

@mwraich mwraich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 6 orders, 3 on V1 and 3 on V1 (counting id 60 and up) and it all looks good.

Made this ticket as a tech-debt clean up to eliminate the duplication.
Screenshot 2024-08-01 at 2 16 21 PM

@zliu7878 zliu7878 merged commit 2f05094 into main Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants