Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add product status to list options #236

Merged
merged 1 commit into from
Sep 28, 2023
Merged

feat: add product status to list options #236

merged 1 commit into from
Sep 28, 2023

Conversation

si-m
Copy link

@si-m si-m commented Sep 27, 2023

In this PR

Add the status query param to the product list options.

Screenshot 2023-09-27 at 10 58 41

Ref: https://shopify.dev/docs/api/admin-rest/2023-07/resources/product#get-products?ids=632910392,921728736

Api version: 2023-07

Note: the type ProductStatus needs to be exported and if we want to expose this query parameter for the list orders endpoint the same needs to happen.

Copy link
Collaborator

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good - just one minor question

product.go Show resolved Hide resolved
@oliver006 oliver006 merged commit 26d463b into bold-commerce:master Sep 28, 2023
3 checks passed
@si-m si-m deleted the feat-add-status-to-product-list-options branch September 29, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants