Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds fulfillment_event and fulfillment_request #244

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

sx328
Copy link

@sx328 sx328 commented Nov 11, 2023

adds fulfillment event resource and fulfillment request resource

comment if any edits

tested OK

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26d463b) 100.00% compared to head (dbcc89d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #244   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        49    +2     
  Lines         2094      2133   +39     
=========================================
+ Hits          2094      2133   +39     
Files Coverage Δ
fulfillment_event.go 100.00% <100.00%> (ø)
fulfillment_request.go 100.00% <100.00%> (ø)
fulfillment_service.go 100.00% <ø> (ø)
goshopify.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the PR!

fulfillment_request.go Show resolved Hide resolved
fulfillment_request.go Show resolved Hide resolved
@oliver006 oliver006 merged commit 030224d into bold-commerce:master Nov 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants