fix: Duplicated notifications #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolshakov
reviewed
Nov 15, 2022
|
@bolshakov I changed the locking mechanism, and I think it's ready for review. |
bolshakov
force-pushed
the
fix-duplicate-notifications
branch
2 times, most recently
from
37dd262
to
adcb55e
Compare
bolshakov
force-pushed
the
fix-duplicate-notifications
branch
from
adcb55e
to
4d65a19
Compare
bolshakov
force-pushed
the
fix-duplicate-notifications
branch
from
ef3530e
to
738c2b0
Compare
bolshakov
reviewed
Nov 30, 2022
bolshakov
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If several instances use the same circuit breaker for connection to third-party service, they may fire duplicated notifications if the connection is unstable.
This PR aims to fix it by introducing notification locks to allow only one notification of the same type to fire across service instances. It will not work if services do not share the data state between them (e.g., if they use the
Memorydata store type and run instances in separate processes/on separate machines).Fixes #125
Fixes #116