Use Redis in specs

.github/workflows/specs.yml

@@ -10,6 +10,17 @@ jobs:
         ruby: ['2.7', '3.0', '3.1' ]
     name: ${{ matrix.ruby }}
 
+    services:
+      redis:
+        image: redis
+        options: >-
+          --health-cmd "redis-cli ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        ports:
+          - 6379:6379
+
     steps:
       - uses: actions/checkout@v3
       - name: Set up ruby
@@ -23,6 +34,8 @@ jobs:
           bundle install --jobs 4 --retry 3
       - name: Test
         run: bundle exec rake spec
+        env:
+          STOPLIGHT_REDIS_URL: "redis://127.0.0.1:6379/0"
       - name: Coveralls
         uses: coverallsapp/github-action@v1.1.2
         with:

Gemfile.lock

@@ -10,16 +10,24 @@ GEM
     ast (2.4.2)
     benchmark-ips (2.7.2)
     bugsnag (4.2.1)
+    database_cleaner-core (2.0.1)
+    database_cleaner-redis (2.0.0)
+      database_cleaner-core (~> 2.0.0)
+      redis
+    debug (1.4.0)
+      irb (>= 1.3.6)
+      reline (>= 0.2.7)
     diff-lcs (1.5.0)
     docile (1.4.0)
     fakeredis (0.8.0)
       redis (~> 4.1)
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
     honeybadger (2.7.2)
+    io-console (0.5.11)
+    irb (1.4.1)
+      reline (>= 0.3.0)
     json (2.3.1)
-    mock_redis (0.34.0)
-      ruby2_keywords
     multipart-post (2.1.1)
     pagerduty (2.1.2)
       json (>= 1.7.7)
@@ -32,6 +40,8 @@ GEM
     redlock (1.3.2)
       redis (>= 3.0.0, < 6.0)
     regexp_parser (2.6.1)
+    reline (0.3.0)
+      io-console (~> 0.5)
     rexml (3.2.5)
     rspec (3.11.0)
       rspec-core (~> 3.11.0)
@@ -58,7 +68,6 @@ GEM
     rubocop-ast (1.24.0)
       parser (>= 3.1.1.0)
     ruby-progressbar (1.11.0)
-    ruby2_keywords (0.0.5)
     sentry-raven (1.2.3)
       faraday (>= 0.7.6, < 0.10.x)
     simplecov (0.21.2)
@@ -78,9 +87,10 @@ PLATFORMS
 DEPENDENCIES
   benchmark-ips (~> 2.3)
   bugsnag (~> 4.0)
+  database_cleaner-redis (~> 2.0)
+  debug
   fakeredis (~> 0.8)
   honeybadger (~> 2.5)
-  mock_redis (~> 0.3)
   pagerduty (~> 2.1.1)
   rake (~> 13.0)
   redis (~> 4.1)

spec/spec_helper.rb

@@ -5,6 +5,7 @@
 require 'stoplight'
 require 'timecop'
 require_relative 'support/data_store/base'
+require_relative 'support/database_cleaner'
 
 Timecop.safe_mode = true
 

spec/stoplight/data_store/redis_spec.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
 
 require 'spec_helper'
-require 'mock_redis'
 
-RSpec.describe Stoplight::DataStore::Redis do
+RSpec.describe Stoplight::DataStore::Redis, :redis do
   let(:data_store) { described_class.new(redis, redlock: redlock) }
-  let(:redis) { MockRedis.new }
   let(:redlock) { instance_double(Redlock::Client) }
   let(:light) { Stoplight::Light.new(name) {} }
   let(:name) { ('a'..'z').to_a.shuffle.join }

spec/support/database_cleaner.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+require 'redis'
+require 'database_cleaner/redis'
+
+cleaning_strategy = DatabaseCleaner::Redis::Deletion.new(only: ["#{Stoplight::DataStore::Redis::KEY_PREFIX}*"])
+DatabaseCleaner.strategy = cleaning_strategy
+
+RSpec.shared_context :redis, :redis do
+  let(:redis) { Redis.new(url: ENV.fetch('STOPLIGHT_REDIS_URL', 'redis://127.0.0.1:6379/0')) }
+
+  before(:suite) do
+    DatabaseCleaner[:redis].db = redis
+    DatabaseCleaner.clean_with(:deletion)
+  end
+
+  around(:each) do |example|
+    DatabaseCleaner.cleaning do
+      example.run
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.include_context :redis, include_shared: true
+end

stoplight.gemspec

@@ -35,9 +35,10 @@ Gem::Specification.new do |gem|
 
   gem.add_development_dependency('benchmark-ips', '~> 2.3')
   gem.add_development_dependency('bugsnag', '~> 4.0')
+  gem.add_development_dependency('database_cleaner-redis', '~> 2.0')
+  gem.add_development_dependency('debug')
   gem.add_development_dependency('fakeredis', '~> 0.8')
   gem.add_development_dependency('honeybadger', '~> 2.5')
-  gem.add_development_dependency('mock_redis', '~> 0.3')
   gem.add_development_dependency('pagerduty', '~> 2.1.1')
   gem.add_development_dependency('rake', '~> 13.0')
   gem.add_development_dependency('redis', '~> 4.1')