Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 support for Bolt 5.0 #2496

Merged
merged 10 commits into from
Mar 31, 2021
Merged

PHP 8.0 support for Bolt 5.0 #2496

merged 10 commits into from
Mar 31, 2021

Conversation

bobdenotter
Copy link
Member

Fixes #2087

@bobdenotter
Copy link
Member Author

This is broken, still:

Screenshot 2021-03-27 at 13 26 54

@bobdenotter
Copy link
Member Author

Bumping into this now:

Screenshot 2021-03-27 at 13 40 20

vendor/bin/behat --tags=api --format=progress -v

In ExtensionManager.php line 194:

  [Behat\Testwork\ServiceContainer\Exception\ExtensionInitializationException]
  `Lakion\Behat\MinkDebugExtension` extension file or class could not be located.

Exception trace:
  at /…/vendor/behat/behat/src/Behat/Testwork/ServiceContainer/ExtensionManager.php:194
 Behat\Testwork\ServiceContainer\ExtensionManager->instantiateExtension() at /…/vendor/behat/behat/src/Behat/Testwork/ServiceContainer/ExtensionManager.php:161
 Behat\Testwork\ServiceContainer\ExtensionManager->initialize() at /…/vendor/behat/behat/src/Behat/Testwork/ServiceContainer/ExtensionManager.php:72
 Behat\Testwork\ServiceContainer\ExtensionManager->activateExtension() at /…/vendor/behat/behat/src/Behat/Testwork/ServiceContainer/ContainerLoader.php:97
 Behat\Testwork\ServiceContainer\ContainerLoader->initializeExtensions() at /…/vendor/behat/behat/src/Behat/Testwork/ServiceContainer/ContainerLoader.php:64
 Behat\Testwork\ServiceContainer\ContainerLoader->load() at /…/vendor/behat/behat/src/Behat/Testwork/Cli/Application.php:185
 Behat\Testwork\Cli\Application->createContainer() at /…/vendor/behat/behat/src/Behat/Testwork/Cli/Application.php:161
 Behat\Testwork\Cli\Application->createCommand() at /…/vendor/behat/behat/src/Behat/Testwork/Cli/Application.php:122
 Behat\Testwork\Cli\Application->doRun() at /…/vendor/symfony/console/Application.php:166
 Symfony\Component\Console\Application->run() at /…/vendor/behat/behat/bin/behat:34

@bobdenotter bobdenotter marked this pull request as ready for review March 29, 2021 15:30
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Hacky fix, me loves.

Let's roll with it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants