Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 'Extract' and 'Extract Name' commands #61

Closed
boltex opened this issue Jun 22, 2020 · 2 comments
Closed

Implement 'Extract' and 'Extract Name' commands #61

boltex opened this issue Jun 22, 2020 · 2 comments
Assignees
@edreamleo @boltex
Labels
enhancement New feature or request

Comments

@boltex
Copy link
Owner

boltex commented Jun 22, 2020

See the 'execute script' command as an example on how to get the selection when a command is issued in order to implement the 'Extract' and 'Extract Name' commands.
@boltex boltex self-assigned this Jun 22, 2020
@boltex boltex added the enhancement New feature or request label Jun 22, 2020
@edreamleo
Copy link
Collaborator

I thought this might work now, but it doesn't. The problem may be that the text selection isn't passed to the command. I'll investigate.

@edreamleo edreamleo self-assigned this Jul 23, 2020
@boltex
Copy link
Owner Author

boltex commented Jul 28, 2020

This (should) depends on #39 .
More specifically: 'Execute script', along with 'Extract' and 'Extract Name' should instead rely on the 'save body to leo' related mechanisms of leoInteg also set its text selection range and cursor position in Leo. From that, the commander. could run those commands with the expected results.

boltex added a commit that referenced this issue Nov 5, 2020
@boltex
Replaced custom executeScript and made extract & extractNames to test…
4b6a80b 
… for body and cursor selection, Closes Implement 'Extract' and 'Extract Name' commands #61
boltex added a commit that referenced this issue Nov 30, 2020
@boltex
Save and restore selection, along with cursor position when switching…
2463605 
… from node to node

Fixes #39  also fixes Implement 'Extract' and 'Extract Name' commands #61
@boltex boltex mentioned this issue Nov 30, 2020
Merged
@boltex boltex closed this as completed Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edreamleo edreamleo

@boltex boltex

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edreamleo @boltex