Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix terraspace output and Enter a value handling #140

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Conversation

tongueroo
Copy link
Contributor

  • Fix terraspace output to not add extra newlines properly
  • Handle stdin prompt "Enter a value" properly.
  • Seems like handling the extra newlines properly fixes the prompt.

This is a 🐞 bug fix.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Context

How to Test

Find a stack that produces rather large output. Compare the terraspace show vs terraform show output. They should be exactly the same. Example:

$ terraspace show vpc --json > /tmp/a.json
Building .terraspace-cache/us-west-2/dev/stacks/vpc
Built in .terraspace-cache/us-west-2/dev/stacks/vpc
Current directory: .terraspace-cache/us-west-2/dev/stacks/vpc
=> terraform show -json
$ cd .terraspace-cache/us-west-2/dev/stacks/vpc ; terraform show -json > /tmp/b.json ; cd -
$ diff /tmp/a.json /tmp/b.json
$ 

Also, do a sanity check that terraspace up and terraspace down work.

Version Changes

Patch

* Fix terraspace output to not add extra newlines properly
* Handle stdin prompt "Enter a value" properly.
* Seems like handling the extra newlines properly fixes the prompt.
@tongueroo tongueroo merged commit 357feae into master Oct 1, 2021
@tongueroo tongueroo deleted the show-newline branch October 1, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant