Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message output #147

Merged
merged 1 commit into from
Oct 27, 2021
Merged

improve error message output #147

merged 1 commit into from
Oct 27, 2021

Conversation

tongueroo
Copy link
Contributor

This is a 🐞 bug fix.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Error messages would get concatenated without newlines after max retries. This joins the final error message with newlines properly so it's readable.

Also added TS_MAX_RETRIES env variable ability.

Context

N/A

How to Test

One way to test is to go from an rather old version of terraform to the latest. If you have already ran terraspace up before, the state file structure is old enough to reproduce. Then running terraspace up with a newer version of Terraform will produce an error about state after terraspace max retries, which is 3. Can reproduce the error faster with:

TS_MAX_RETRIES=0 terraspace up demo

Version Changes

Patch

@tongueroo tongueroo merged commit 034d8f0 into master Oct 27, 2021
@tongueroo tongueroo deleted the error-message branch October 27, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant