dont fork when all.concurrency = 1 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Released in 1.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🙋♂️ feature or enhancement.
bundle exec rspecto verify this)Summary
The
terraspace allcommands will not fork whenall.concurrency <= 1. This should, in theory, allow it to work with windows, sinceforkis linux specific. Yes, it's a workaround.Note: When this non-forking mode is activated
terraspace allsummarized logging is disabled and all the logs are streamed to the current terminal.Context
fork()when concurrency is1#206How to Test
Try https://github.com/boltops-tools/terraspace-graph-demo with
all.concurrency = 1enabled.Version Changes
Patch