Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all down by building child nodes #215

Merged
merged 1 commit into from
Feb 22, 2022
Merged

fix all down by building child nodes #215

merged 1 commit into from
Feb 22, 2022

Conversation

tongueroo
Copy link
Contributor

@tongueroo tongueroo commented Feb 22, 2022

This is a 🐞 bug fix.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Fix terraspace all down.

The #196 change in v1.1.0 means only required stacks are built. It works for terraspace all up, and then terraspace all down would work as long as the .terraspace-cache folder still exist.

However, on a clean machine without .terraspace-cache, terraspace all down wouldn't work because the dependent stacks were not built and available for terraform state pull to work.

This fixes the issue by building the dependent stacks. Additionally, added a codebuild project with an acceptance test for terraspace all has been added. See: #216

Context

How to Test

git clone https://github.com/boltops-tools/terraspace-graph-demo
cd terraspace-graph-demo
terraspace all up -y
terraspace clean all -y
terraspace all down -y # should work

Version Changes

Patch

@tongueroo
Copy link
Contributor Author

Released in 1.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant