Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tainting/untainting as a terraspace command #331

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

AHaymond
Copy link
Contributor

This is a πŸ™‹β€β™‚οΈ feature or enhancement.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Taint and untaint are very useful Terraform commands when you need to force the replacement of a resource. Moving these subcommands as first class citizens for Terraspace reduces overhead in management by no longer requiring a need to shift to the cache directory to drop into the terraform cli to perform such tasks.

This pull request adds them to the Terraspace list of subcommands that can easily be carried out without having to navigate to a cache directory.

Context

No context known of

Version Changes

unknown

@danielcbaldwin
Copy link

One of the few last things I need to "cd" into the cache directory for. Would be great to have this.

@mhjenkins
Copy link

Thanks @AHaymond! This will be really nice!

@gradyplayer
Copy link

Seems completely reasonable LGTM... (for all that is worth)

@AHaymond
Copy link
Contributor Author

AHaymond commented Oct 6, 2023

Any movement on bumping this command to a first class citizen?

@tongueroo
Copy link
Contributor

Been a little busy. Will try to take a look soon. Mainly just needs some testing.

@AHaymond
Copy link
Contributor Author

AHaymond commented Oct 9, 2023

It sure would be nice to have to do less traversal into the cache folder to utilize underlying Terraform commands. A good alternative would be to create a pass through such as terraspace tc [stack] [terraform commands and arguments]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants