Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boot hooks #90

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Boot hooks #90

merged 2 commits into from
Mar 5, 2021

Conversation

tongueroo
Copy link
Contributor

This is a 🙋‍♂️ feature or enhancement.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

  • boot hook runs even earlier, before bundle setup
  • boot hook didn't really allow setting env vars because it wasn't running early enough. so fine to remove it now.

Context

https://community.boltops.com/t/customized-layering-support/632/9

How to Test

Create

config/hook.rb

puts "Running config/boot.rb"
ENV['TS_ENV']      = "foo"

Run

terraspace build demo
ls .terraspace-cache/us-west-2/foo/stacks/demo

Version Changes

Patch

@tongueroo tongueroo merged commit 6b134cb into master Mar 5, 2021
@tongueroo tongueroo deleted the boot-hooks branch March 5, 2021 03:09
@tongueroo tongueroo mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tongueroo