Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTelemetry gRPC protocol support #112

Merged
merged 22 commits into from
Feb 26, 2021
Merged

OpenTelemetry gRPC protocol support #112

merged 22 commits into from
Feb 26, 2021

Conversation

grzkv
Copy link
Member

@grzkv grzkv commented Dec 30, 2020 •
edited
Loading

This PR implements gRPC protocol for both listening and sending to a target.

Details:

  • There are still parts missing that are not essential for the protocol to work. These are commented about in the code.
  • The protocol for now completely repeats the line protocol as closely as possible. This is temporary.
  • The main body of changes are refectorings of listening and sending designs.

Testing

  • performed manual testing for listen and send
  • performed manual tests stringing several NTs via gRPC protocol and sending bursts of messages

@grzkv grzkv marked this pull request as draft December 30, 2020 15:29
@grzkv grzkv changed the title [WIP] gRPC protocol support gRPC protocol support Jan 15, 2021
@grzkv grzkv marked this pull request as ready for review January 15, 2021 12:20
@grzkv grzkv changed the title gRPC protocol support OpenTelemetry gRPC protocol support Feb 3, 2021
grzkv and others added 18 commits February 15, 2021 15:44
@grzkv
Added draft gRPC server. Refactored the listener. Updated the proto i…
f9e646c 
…nterface.
@grzkv
Added configs for manual gRPC testing.
1382e2b
@grzkv
Added correct handling of stream closure on the server.
dccbef0
@grzkv
Added config docs and tracing.
352586a
@grzkv
Added gRPC server keepalive options. Removed useless config test.
84e9c8c
@grzkv
Added polymorphic target host construction.
664bbd5
@grzkv
Added connection retry for gRPC client.
5107ea3
@grzkv
Finished client logic, added proper termination.
1c6cabd
@grzkv
Manual testing setup for gRPC.
35dc1b0
@grzkv
Added opentelemetry v0.7.0 proto files.
6836d55
@grzkv
Organized inclusion of opentelemetry proto files with correct resulti…
4babc7d 
…ng go package and include paths.
@grzkv
Finished switch to OpenTelemetry. Switched to using Google's implemen…
a533ca4 
…tation of pb for now.
@grzkv
Fixed temporary record serialization.
13ee5f5
@dams @grzkv
update linter version
3619aed 
use newer version to have better linting and error detection
@grzkv
fix bug uncovered by linter
acf75c8
@grzkv
Avoid server closing the connection in case client sends keepalive du…
822c476 
…ring a prolonged period or without sending a message first.
@grzkv
Added correct behavior when server is going away and coming back repe…
6a0e83d 
…atedly.
@grzkv
end-to-end testing test2
ed28403
@grzkv grzkv merged commit 7a35923 into master Feb 26, 2021
@grzkv grzkv deleted the grzkv/grpc branch February 26, 2021 16:09
@grzkv grzkv mentioned this pull request Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avereha avereha Awaiting requested review from avereha

@dams dams Awaiting requested review from dams

@grlvrl grlvrl Awaiting requested review from grlvrl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grzkv @dams