Merge pull request #49 from boomerang-io/fix-ISEEC-2378-ui-shell-acce…

…ssibility

Fix iseec 2378 UI shell accessibility

package.json

@@ -49,24 +49,20 @@
   },
   "dependencies": {
     "@carbon/elements": "^10.21.0",
-    "@carbon/themes": "^10.21.0",
     "@stomp/stompjs": "^5.4.2",
     "@tippyjs/react": "^4.0.2",
     "carbon-icons": "^7.0.7",
     "classnames": "^2.2.5",
     "date-fns": "^1.30.1",
     "dompurify": "^2.0.6",
     "downshift": "^5.2.1",
-    "invariant": "^2.2.3",
+    "focus-trap-react": "^8.9.1",
     "js-file-download": "^0.4.7",
-    "lodash.isequal": "^4.5.0",
     "match-sorter": "^4.2.1",
     "react-autosuggest": "^9.4.3",
     "react-dropzone": "^10.0.6",
-    "react-focus-trap": "^2.7.1",
     "react-modal": "^3.10.1",
     "react-toastify": "^5.3.2",
-    "warning": "^4.0.3",
     "window-or-global": "^1.0.1"
   },
   "peerDependencies": {

src/components/AboutPlatform/AboutPlatform.js

@@ -76,6 +76,7 @@ const AboutPlatformContainer = ({ version, organization, isFlowApp }) => {
                   <li key="kubernetes-icon">
                     <a href="https://kubernetes.io/" target="_blank" rel="noopener noreferrer">
                       <KubernetesIcon
+                        alt="Kubernetes Icon"
                         className={`${prefix}--bmrg-aboutPlatform-images__img`}
                       />
                     </a>

src/components/ComboBoxMultiSelect/ComboBoxMultiSelect.spec.js

@@ -50,7 +50,7 @@ test('select and remove items', async () => {
     expect(queryByLabelText(/Clear filter cat/i)).toBeInTheDocument();
   });
 
-  const clearButton = getByRole('button', { name: 'Clear Selection' });
+  const clearButton = getByRole('button', { name: 'Clear selected item' });
   fireEvent.click(clearButton);
   await waitFor(() => {
     expect(queryByLabelText(/Clear filter panda/i)).not.toBeInTheDocument();

src/components/Error403/Error403.spec.js

@@ -4,8 +4,8 @@ import Error403 from './Error403';
 
 test('render Error403 with defaults', async () => {
   const { getByText } = render(<Error403 />);
-  expect(getByText('403 - Access Forbidden')).toBeInTheDocument();
-  expect(getByText('You’ve found yourself in deep water.')).toBeInTheDocument();
+  expect(getByText('403 Access Forbidden')).toBeInTheDocument();
+  expect(getByText(`Looks like you've taken a wrong turn.`)).toBeInTheDocument();
   expect(
     getByText('You shouldn’t be here - contact the local authorities if you disagree.')
   ).toBeInTheDocument();
@@ -14,7 +14,7 @@ test('render Error403 with defaults', async () => {
 test('render Error403 without text', async () => {
   const { queryByText } = render(<Error403 header={null} title={null} message={null} />);
   expect(queryByText('403 - Access Forbidden')).not.toBeInTheDocument();
-  expect(queryByText('You’ve found yourself in deep water.')).not.toBeInTheDocument();
+  expect(queryByText(`Looks like you've taken a wrong turn.`)).not.toBeInTheDocument();
   expect(
     queryByText('You shouldn’t be here - contact the local authorities if you disagree.')
   ).not.toBeInTheDocument();

src/components/Error404/Error404.spec.js

@@ -5,15 +5,15 @@ import Error404 from './Error404';
 
 test('render Error404 with defaults', async () => {
   const { getByText } = render(<Error404 />);
-  expect(getByText('404 - Page Not Found')).toBeInTheDocument();
-  expect(getByText('Crikey. Something seems to have swam off with this page.')).toBeInTheDocument();
+  expect(getByText('404 Page Not Found')).toBeInTheDocument();
+  expect(getByText('We spaced out and couldn’t find your page.')).toBeInTheDocument();
   expect(getByText('Try refreshing, or contact the local authorities.')).toBeInTheDocument();
 });
 
 test('render Error404 without text', async () => {
   const { queryByText } = render(<Error404 header={null} title={null} message={null} />);
-  expect(queryByText('403 - Access Forbidden')).not.toBeInTheDocument();
-  expect(queryByText('You’ve found yourself in deep water.')).not.toBeInTheDocument();
+  expect(queryByText('404 Page Not Found')).not.toBeInTheDocument();
+  expect(queryByText('We spaced out and couldn’t find your page.')).not.toBeInTheDocument();
   expect(
     queryByText('You shouldn’t be here - contact the local authorities if you disagree.')
   ).not.toBeInTheDocument();