feat(ui-shell): Made the PR fixes

boomerang-io · Jan 28, 2022 · f0f603b · f0f603b
1 parent 2dee7c7
commit f0f603b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/components/Feedback/Feedback.js b/src/components/Feedback/Feedback.js
@@ -14,10 +14,6 @@ const { prefix } = settings;
 
 class Feedback extends Component {
 
-  handleCloseModal = (closeModal) => {
-    closeModal();
-  };
-
   render() {
     return (
       <HeaderMenuItem
@@ -31,7 +27,7 @@ class Feedback extends Component {
             <>
               <ModalHeader
                 title="Submit an Idea"
-                closeModal={() => this.handleCloseModal(closeModal)}
+                closeModal={closeModal}
               />
               <ModalBody>
                 <div className={`${prefix}--bmrg-feedback`}>
@@ -58,7 +54,7 @@ class Feedback extends Component {
                 </div>
               </ModalBody>
               <ModalFooter>
-                <Button kind="secondary" onClick={() => this.handleCloseModal(closeModal)}>
+                <Button kind="secondary" onClick={closeModal}>
                   OK
                 </Button>
               </ModalFooter>

diff --git a/src/components/UIShell/UIShell.js b/src/components/UIShell/UIShell.js
@@ -32,6 +32,11 @@ UIShell.propTypes = {
    */
   companyName: PropTypes.string,
 
+  /**
+   * used to redirect the users to a submit idea portal under feedback
+   */
+  sendIdeasUrl: PropTypes.string,
+
   /**
    * Pass in whole header config object used for
    * - Feature flagging
@@ -158,6 +163,7 @@ UIShell.defaultProps = {
   renderPrivacyStatement: true,
   user: {},
   renderRightPanel: {},
+  sendIdeasUrl: "https://ideas.ibm.com",
 };
 
 function UIShell({
@@ -179,6 +185,7 @@ function UIShell({
   renderSidenav,
   skipToContentProps,
   user,
+  sendIdeasUrl,
 }) {
   const finalPlatformName = platformName || companyName;
   const finalAppName = appName || productName;
@@ -260,7 +267,7 @@ function UIShell({
             />
           ),
           isFeedbackEnabled && (
-            <Feedback platformName={platformName} sendIdeasUrl="https://ideas.ibm.com" key="Feedback" />
+            <Feedback platformName={platformName} sendIdeasUrl={sendIdeasUrl} key="Feedback" />
           ),
         ].filter(Boolean)}
         profileChildren={[