Fix security issues #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timrbula
commented
Jun 20, 2022
| "react-modal": "3.14.4", | ||
| "react-toastify": "8.2.0", | ||
| "react-modal": "3.15.1", | ||
| "react-toastify": "9.0.5", |
There was a problem hiding this comment.
Major version upgrade that added some new features. The breaking changes don't affect us and notifcations are still working just fine in the storybook and in app.
BenjaminRuby
approved these changes
Jun 22, 2022
This was referenced Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #62 #63 #64 #65
https://deploy-preview-66--carbon-addons-boomerang-react.netlify.app/
2.0.6-beta.0
Checklist:
PR Review Guidance
Made some dependency upgrades and verified them locally. Tests are passing. Will verify in built environment as well.
Additional Info
Confirmed with local application with dev and prod builds