fix: remove sockjs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timrbula
commented
Jul 15, 2022
| @@ -228,7 +228,7 @@ function UIShell({ | |||
| skipToContentProps={skipToContentProps} | |||
| requestSummary={user.requestSummary} | |||
| notificationsConfig={{ | |||
| wsUrl: `${finalBaseServiceUrl}/notifications/ws`, | |||
| wsUrl: `${finalBaseServiceUrl}/notifications/ws`.replace("https://", "wss://"), | |||
There was a problem hiding this comment.
Meh, but I'm not sure of a better way to do this without requesting service changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Jira Issue: ISEEC-4122
Build Number: 2.0.10-alpha.3
Checklist:
PR Review Guidance
Remove SockJS and use stomp to make native ws connection without fallback
Additional Info
Hopefully this solves some issues w/ the SockJS client blocking other requests. We also get to remove the SockJS client code and the changes required to support it