-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat 38 typescript #95
Conversation
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Tim, I don't see any errors and the lib is building normally!
Only thing: there are still some commented "@ts-expect-error" that weren't adressed.
Thanks @LucasGrimauth I will fix those |
@LucasGrimauth I think this is finally in good enough shape to merge and publish. There is room for improvement in the types, but overall I think it's ok to go with and we can improve from there. I got rid of majority of the errors, only two |
TypeScript migration
Context
GitHub Issue: Closes #38
Version Number: 3.2.0
Checklist
PR Review Guidance
Additional Info
Woot