Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 38 typescript #95

Merged
merged 42 commits into from
Dec 23, 2022
Merged

Feat 38 typescript #95

merged 42 commits into from
Dec 23, 2022

Conversation

timrbula
Copy link
Member

@timrbula timrbula commented Nov 4, 2022

TypeScript migration

Context

GitHub Issue: Closes #38

Version Number: 3.2.0

Checklist

  • Has been verified in an integrated environment
  • Has relevant unit and integration tests passing
  • Has no linting, test console, or browser console errors (best effort)

PR Review Guidance

  1. Types look ok
  2. Build commands work as expected

Additional Info

Woot

@timrbula timrbula marked this pull request as ready for review December 14, 2022 15:46
LucasGrimauth
LucasGrimauth previously approved these changes Dec 14, 2022
Copy link
Member

@LucasGrimauth LucasGrimauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tim, I don't see any errors and the lib is building normally!
Only thing: there are still some commented "@ts-expect-error" that weren't adressed.

@timrbula
Copy link
Member Author

Hey Tim, I don't see any errors and the lib is building normally! Only thing: there are still some commented "@ts-expect-error" that weren't adressed.

Thanks @LucasGrimauth I will fix those

@timrbula
Copy link
Member Author

timrbula commented Dec 15, 2022

@LucasGrimauth I think this is finally in good enough shape to merge and publish. There is room for improvement in the types, but overall I think it's ok to go with and we can improve from there. I got rid of majority of the errors, only two // @ts-* comments remain. There are a lot of anys throughout but we can improve those over time and make types more useful, particularly in the event handlers and spread props

@timrbula timrbula merged commit e4e995e into main Dec 23, 2022
@timrbula timrbula deleted the feat-38-typescript branch December 23, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types
2 participants