Fix UI shell refactor #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timrbula
commented
Jan 17, 2023
| @@ -86,7 +86,7 @@ function ProfileSettings({ baseServicesUrl, src, userName, isOpen, closeModal }: | |||
| setTeams(initialTeams); | |||
| } | |||
|
|
|||
| async function handleSubmit({ closeModal }: { closeModal: Function }) { | |||
There was a problem hiding this comment.
closeModal is already defined within the component scope via a prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Template
Context
GitHub Issue: N/A
Version Number: 4.0.0
Checklist
PR Review Guidance
Make sure that when you open the PrivacyStatement confirm modal and exit out of it, you can re-open it without having to close the overall modal and the user profile menu.
Currently if you close the confirm modal but clicking outside of it it but within the larger privacy statement modal or use the X button, you can't reopen it without closing the entire user profile menu to un-mount it.
Additional Info
All did some small cleanup and added better types