Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global event handler #1404

Merged
merged 12 commits into from
Jun 11, 2024
Merged

Conversation

gonzalojaubert
Copy link
Contributor

Description

Add a global event handler

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@ghost
Copy link

ghost commented May 9, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@charlietfe charlietfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gonzalogarciajaubert gonzalogarciajaubert marked this pull request as draft October 26, 2023 13:51
Castro, Mario added 3 commits June 4, 2024 10:46
# Conflicts:
#	packages/framework-core/src/booster-event-dispatcher.ts
#	packages/framework-core/src/decorators/index.ts
#	packages/framework-core/test/booster-event-dispatcher.test.ts
@MarcAstr0 MarcAstr0 marked this pull request as ready for review June 5, 2024 14:57
@MarcAstr0
Copy link
Collaborator

About commit f9b730e: this commit fixes an issue introduced in v2.11 (related to PR #1481).

The issue in question is changing Cosmos DB SQL queries so they use square brackets instead of dot notation for properties. i.e., a SQL query such as SELECT c.id FROM c is changed to SELECT c["id"] FROM c.

This prevents that Cosmos throws syntax errors when there are properties in the read model that are also reserved Cosmos DB keywords (e.g., value). This issue was found when running this integration test.

@MarcAstr0
Copy link
Collaborator

/integration sha=f9b730e8b88d6b0004f08eb0637f66ebfaffcd12

Copy link
Contributor

github-actions bot commented Jun 5, 2024

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Oh no! Integration tests have failed

Copy link
Contributor

github-actions bot commented Jun 5, 2024

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ Integration tests have finished successfully!

@MarcAstr0
Copy link
Collaborator

/integration sha=ac8e2bd377f47f9d9853e917f736a6229a831640

Copy link
Contributor

github-actions bot commented Jun 6, 2024

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

github-actions bot commented Jun 6, 2024

✅ Integration tests have finished successfully!

@MarcAstr0 MarcAstr0 force-pushed the add_global_event_handler branch from ac8e2bd to 3ef5080 Compare June 7, 2024 12:27
@MarcAstr0
Copy link
Collaborator

/integration sha=3ef5080f0197c4e895d6e332114a9881fe7f5601

Copy link
Contributor

github-actions bot commented Jun 7, 2024

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

github-actions bot commented Jun 7, 2024

✅ Integration tests have finished successfully!

@MarcAstr0
Copy link
Collaborator

/integration sha=1aeaf9c

Copy link
Contributor

github-actions bot commented Jun 7, 2024

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

github-actions bot commented Jun 7, 2024

✅ Integration tests have finished successfully!

@MarcAstr0
Copy link
Collaborator

/integration sha=4b970ce91b45f61a52da045a7e46f5b06cc96f8c

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@MarcAstr0
Copy link
Collaborator

@alvaroloes your suggestions have been applied in commit 4b970ce

@MarcAstr0 MarcAstr0 requested a review from alvaroloes June 11, 2024 14:40
Copy link
Contributor

@alvaroloes alvaroloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Check the unneeded comment

Copy link
Contributor

✅ Integration tests have finished successfully!

@MarcAstr0
Copy link
Collaborator

Closes PR #1535

@MarcAstr0 MarcAstr0 merged commit 879ef44 into boostercloud:main Jun 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants