-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global event handler #1404
Add global event handler #1404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # packages/framework-core/src/booster-event-dispatcher.ts # packages/framework-core/src/decorators/index.ts # packages/framework-core/test/booster-event-dispatcher.test.ts
About commit f9b730e: this commit fixes an issue introduced in v2.11 (related to PR #1481). The issue in question is changing Cosmos DB SQL queries so they use square brackets instead of dot notation for properties. i.e., a SQL query such as This prevents that Cosmos throws syntax errors when there are properties in the read model that are also reserved Cosmos DB keywords (e.g., |
/integration sha=f9b730e8b88d6b0004f08eb0637f66ebfaffcd12 |
⌛ Integration tests are running... Check their status here 👈 |
❌ Oh no! Integration tests have failed |
⌛ Integration tests are running... Check their status here 👈 |
✅ Integration tests have finished successfully! |
/integration sha=ac8e2bd377f47f9d9853e917f736a6229a831640 |
⌛ Integration tests are running... Check their status here 👈 |
✅ Integration tests have finished successfully! |
ac8e2bd
to
3ef5080
Compare
/integration sha=3ef5080f0197c4e895d6e332114a9881fe7f5601 |
⌛ Integration tests are running... Check their status here 👈 |
✅ Integration tests have finished successfully! |
/integration sha=1aeaf9c |
⌛ Integration tests are running... Check their status here 👈 |
✅ Integration tests have finished successfully! |
packages/framework-integration-tests/src/event-handlers/global-handler.ts
Outdated
Show resolved
Hide resolved
/integration sha=4b970ce91b45f61a52da045a7e46f5b06cc96f8c |
⌛ Integration tests are running... Check their status here 👈 |
@alvaroloes your suggestions have been applied in commit 4b970ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Check the unneeded comment
✅ Integration tests have finished successfully! |
Closes PR #1535 |
Description
Add a global event handler
Checks