-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade for Node 18 compatibility #1431
Conversation
PR Summary
|
Oops, looks like you forgot to add a changeset.
This command will prompt you for a change description and generate a changeset file. You can read more about changesets here. Remember that you should use the version bump that is appropriate for the change you are making:
If you are unsure about which version bump to use, please ask in the comments and we will help you out. |
@@ -18,7 +18,7 @@ export function lambda( | |||
apis: APIs | |||
): Pick<FunctionProps, 'runtime' | 'timeout' | 'memorySize' | 'environment'> { | |||
return { | |||
runtime: Runtime.NODEJS_14_X, | |||
runtime: Runtime.NODEJS_18_X, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Azure infrastructure also defines the runtime version in terraform-function-app.ts file. Current version is Node 14:
siteConfig: {
applicationStack: {
nodeVersion: '~14',
},
},
I think we should update it too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think the functionsExtensionVersion: '~3'
needs to be updated to functionsExtensionVersion: '~4'
in the same file
75bc40d
to
7e69a61
Compare
7d90a88
to
5a263d5
Compare
5a263d5
to
5e85f6e
Compare
/integration sha= 5e85f6e |
⌛ Integration tests are running... Check their status here 👈 |
✅ Integration tests have finished successfully! |
@javiertoledo Just an observation: if we want to upgrade the Nodejs runtime to v18, but keep AWS SDK to v2, we'd have to deploy AWS SDK v2 with each lambda. Alternatively, we can upgrade to AWS SDK v3 which comes preloaded with the v18 runtime. Also, the deprecated package |
@samueldominguez very good observation. Let's upgrade the SDK to v3 before merging this branch. I've created a new issue to track this: #1459 |
I've moved all pending tasks to separate issues and retargeted this PR to the new |
In this branch we're working on a big upgrade to remove deprecated dependencies and start using Node 18.
TODO
Checks