Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Azure subscription ID when instancing AzurermProvider object #1556

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

MarcAstr0
Copy link
Collaborator

@MarcAstr0 MarcAstr0 commented Oct 25, 2024

Description

cdktf and the azurerm provider are now requiring that the Azure subscription ID is present on the AzurermProvider. Otherwise, it will give the following error during deployment:

Error: `subscription_id` is a required provider property when performing a plan/apply operation

Changes

  • Added subscriptionId property when instancing AzurermProvider in the ApplicationSynth class.

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@MarcAstr0 MarcAstr0 added the bug Something isn't working label Oct 25, 2024
@MarcAstr0 MarcAstr0 requested a review from davidverdu October 25, 2024 15:19
Copy link

what-the-diff bot commented Oct 25, 2024

PR Summary

  • Introduction of JSON Change Log
    A new documentation file has been added that records any modifications made to a key component of our product, named @boostercloud/framework-core. One key update noted there is the obligatory inclusion of a subscriptionId detail.

  • Updates to ApplicationSynth Class
    The class responsible for synthesizing our application has seen couple alterations:

    • It now includes a newly imported module that caters to parameters configuration.
    • There is now a requirement for the subscriptionId detail in the azurermProvider configuration, particularly when deploying on Azure platform.

@MarcAstr0
Copy link
Collaborator Author

/integration sha=0b2f22c9f720370ab3d0f8e8df660240adb4d8c2

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

❌ Oh no! Integration tests have failed

2 similar comments
Copy link
Contributor

❌ Oh no! Integration tests have failed

Copy link
Contributor

❌ Oh no! Integration tests have failed

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

❌ Oh no! Integration tests have failed

1 similar comment
Copy link
Contributor

❌ Oh no! Integration tests have failed

Copy link
Contributor

✅ Integration tests have finished successfully!

@MarcAstr0 MarcAstr0 merged commit cedee76 into boostercloud:main Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants