Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msvc-14.0 and clang-win to GHA Windows jobs #169

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Conversation

Flamefire
Copy link
Collaborator

The clang-win job requires embed-manifest-via=linker

See run at https://github.com/boostorg/boost-ci/runs/6789632405?check_suite_focus=true
and upstream issue bfgroup/b2#159

@pdimov We had that in Boost.Unordered. I think it makes sense to put that here instead of unconditionally add it everywhere.

Note that the Appveyor clang-win job works without this flag: https://ci.appveyor.com/project/Flamefire/boost-ci/builds/43769849/job/4a9kgqgbb9dmiek0

Hence I only add it for GHA.

@pdimov
Copy link
Member

pdimov commented Jun 8, 2022

I can't think of anything wrong with using the linker unconditionally. I've suggested this be made default in b2 but the suggestion hasn't been taken up.

Appveyor probably works because it uses an earlier Windows SDK, so the clang-win toolset is able of autodetecting the path to mt.exe there.

Add embed-manifest-via=linker to B2_FLAGS when clang-win is used on
Github actions
@Flamefire
Copy link
Collaborator Author

I can't think of anything wrong with using the linker unconditionally. I've suggested this be made default in b2 but the suggestion hasn't been taken up.

If that gets implemented we can remove the workaround here. Until then I'd try and stay as close to what a user would do, which is likely using b2 without that flag. Hence only use that flag where we know it to be required.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #169 (0c22052) into master (376479c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #169   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           20        20           
  Branches        10        10           
=========================================
  Hits            20        20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376479c...0c22052. Read the comment docs.

@Flamefire Flamefire merged commit fb621d3 into master Jun 8, 2022
@Flamefire Flamefire deleted the windows_jobs branch June 8, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants