-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI jobs for MinGW32/64 #322
Conversation
|
So the build should be skipped by Lines 126 to 137 in 5dc58be
If you consider it not worth ensuring this skipping works in this specific configuration I can remove that.
I can C&P the steps from the posix jobs if you prefer that. I used boost-ci to reduce repetition
The ones added here use the MSYS2 MinGW-w64 distros for 32 & 64 bit. On a Windows machine those are called "MSYS2 MinGW x86" and "MSYS2 MinGW x64" respectively. The reason for using MSYS2 is (to quote from their website):
--> The currently tested GCC is GCC-8, MSYS2 uses GCC-13. So this adds testing for recent GCCs on Windows |
I see no point in running a C++03 CI build when it is not expected to work (whether with an error or silently skip the build is not important).
Yes, that would be ok, if those steps work on MSYS2.
Ok, but the 32-bit build fails as if its Windows SDK headers are incomplete, which makes me suspect it's MinGW32 rather than a 32-bit target of MinGW-w64. |
32 bit version of MinGW-64 __MINGW64__ is not defined
The intention was to verify the skipping works, i.e. the linked code does what it is supposed to. But I removed the jobs.
The 32-bit MinGW-w64 does not define I.e. the struct is only accessible to drivers and there wasn't a configuration tested yet that relied on it to be defined by a Windows SDK header |
CI is passing now in all configs after unconditionally declaring the struct only available to drivers. Anything else? |
Thank you. |
Add jobs using MSYS2 MinGW to GHA
Config copied from boost-ci
This is the configuration where I see #321 although it seems to be only triggered by
-Wextra
not-Wall
: https://godbolt.org/z/3fqjG7zM3