[test] add cases for issues #1229 #1231 #1244 and some test refactoring #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and some test refactoring
barendgehrels
commented
Mar 3, 2024
|
|
||
| // Change compiler defines to constexpr bools | ||
| // to make conditions more readable | ||
| // and to always compile all code. |
There was a problem hiding this comment.
This is done in difference.cpp only, until now.
If you agree, I'll apply it in the others too. And we can apply it everywhere.
Advantages:
ifi/oifdef- code is always compiled
- easier to read
Also, we can harmonize it with the removing of the rescaling, as done in this source file.
barendgehrels
commented
Mar 3, 2024
| @@ -41,10 +68,12 @@ | |||
| ( #caseid, caseid[0], caseid[1], clips1, -1, area1, clips2, -1, area2, \ | |||
| clips3, -1, area1 + area2, settings) | |||
|
|
|||
| template <typename P> | |||
| template <typename P, bool ClockWise> | |||
There was a problem hiding this comment.
I added ccw tests for difference, it was not earlier there. Most cases work, but a few of them don't - they are now conditionally
barendgehrels
commented
Mar 3, 2024
| example_star, clip, | ||
| 4, 16, 0.833333, 4, 20, 2.833333); | ||
| using box = bg::model::box<P>; | ||
| using ring = bg::model::ring<P>; |
There was a problem hiding this comment.
changes in the block below are mainly whitespace
barendgehrels
commented
Mar 3, 2024
| TEST_DIFFERENCE(issue_1231, 1, 203161.751, 2, 1237551.0171, 1); | ||
| } | ||
|
|
||
| if BOOST_GEOMETRY_CONSTEXPR(! is_ccw || test_failures) |
There was a problem hiding this comment.
@awulkiew I assume this is fine, and an else branch is not needed in such cases
vissarion
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.