-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gsoc2019] Otsu threshold implemented #314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miralshah365 This looks good.
Here is my first batch of comments clearing some trivial aspects of the code.
Could you also try to update your PR against latest develop
where Olzhas merged his PR,
and you will need to resolve the conflict in test/core/image_processing/Jamfile
.
When you will be updating, please do regular true git merge
and git push
,
but not git rebase
and git push --force
.
The issue is that rebase and forced-push update lose tracking of history of review comments.
Later today, I will do another round of comments and run proper testing of your code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miralshah365 Please, "Resolve conversation" for addressed comments.
@miralshah365 I've started discussion related to review of this PR (and previous #310 feature too),. Please, see the thread Global binarization vs multi-channel binarization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review with suggestion for better naming of variables
- self-descriptive and evident
- C++ standard library-like, but not of form of any CamelCase
13b47d9
to
1c24ffa
Compare
1c24ffa
to
589fb28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miralshah365 LGTM! Feel free to merge.
Please, consider adding a test case with gray8_image_t
(in separate PR).
589fb28
to
36c8734
Compare
36c8734
to
97f2f6a
Compare
Description
New method threshold_optimal introduced. In this method, the user does not need to specify any threshold value but is chosen by the Otsu's algorithm. More details about the algorithm can be found in the reference.
If the image is multi-channel then the algorithm is applied on each channel. If the image has channel depth more than 8bit then each channel is normalized to fit in the range from 0 to 255.
References
closes #311
http://www.labbookpages.co.uk/software/imgProc/otsuThreshold.html
Tasklist